In this paper, a vector modal expansion method is used to investigate the diffraction efficiency of optical vector waves for a perfectly conducting reflection grating with grooves of arbitrary cross-section. The results for the special cases of p-and s-polarization are well consistent with that given by ref.[2].